fix: Fix parsing of legacy transactions without chain ID#762
Merged
Conversation
ptrus
force-pushed
the
ptrus/fix/legacy-tx-parsing
branch
from
19c2c53 to
d5dacad
Compare
kostko
approved these changes
Jul 31, 2025
ptrus
force-pushed
the
ptrus/fix/legacy-tx-parsing
branch
from
d5dacad to
0ef2d6a
Compare
Newer go-ethereum versions reject a zero `chainID` in `LatestSignerForChainID`. For legacy transactions without a chain ID, we now correctly pass `nil`.
ptrus
force-pushed
the
ptrus/fix/legacy-tx-parsing
branch
from
0ef2d6a to
c5d57ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer go-ethereum versions reject a zero
chainIDinLatestSignerForChainID. For legacy transactions without a chain ID, we now correctly passnil.TODO: